Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify lint action #612

Merged
merged 2 commits into from
Jun 20, 2024
Merged

ci: simplify lint action #612

merged 2 commits into from
Jun 20, 2024

Conversation

DaniBodor
Copy link
Collaborator

@DaniBodor DaniBodor commented Jun 18, 2024

Linting doesn't require the entire package to be built, merely ruff to be installed.

Note that the lint action only takes 7 sec now, compared to e.g. 5 min in #611

@DaniBodor DaniBodor requested a review from gcroci2 June 18, 2024 15:09
@DaniBodor DaniBodor force-pushed the simplify_lint_action_dbodor branch 2 times, most recently from 15c7092 to 253c51c Compare June 18, 2024 18:21
this action doesn't require the entire package to be built, merely ruff to be installed.
@DaniBodor DaniBodor force-pushed the simplify_lint_action_dbodor branch from 253c51c to bc025d9 Compare June 18, 2024 18:21
Copy link
Collaborator

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D

Linting is now failing, because of changes in ruff I guess. Pls fix that and feel free to merge

@DaniBodor DaniBodor merged commit e28dbce into dev Jun 20, 2024
5 checks passed
@DaniBodor DaniBodor deleted the simplify_lint_action_dbodor branch June 20, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants